[AppKit] Xcode 14 Beta 1-5 #15778

chamons · 2022-08-25T22:12:42Z

No description provided.

src/AppKit/Enums.cs

dalexsoto · 2022-08-26T12:57:42Z

src/appkit.cs

+		[Mac (13, 0)]
+		[Export ("pulldownTarget", ArgumentSemantic.Weak)]
+		[NullAllowed]
+		NSObject PulldownTarget { get; set; }
+
+		[Mac (13, 0)]
+		[Export ("pulldownAction", ArgumentSemantic.Assign)]
+		[NullAllowed]
+		Selector PulldownAction { get; set; }


I wonder if we can provide a better API in the future

src/appkit.cs

src/xkit.cs

Co-authored-by: Alex Soto <alex@alexsoto.me>

rolfbjarne · 2022-08-26T16:06:06Z

src/xkit.cs

+	[Flags]
+	[Native]
+	public enum NSTextListOptions : ulong {
+		PrependEnclosingMarker = 1


Suggested change

PrependEnclosingMarker = 1

PrependEnclosingMarker = 1,

rolfbjarne · 2022-08-26T16:06:36Z

src/xkit.cs

+		Decimal,
+	}
+
+	[TV (16,0), NoWatch, Mac (10,10), iOS (16,0)]


MacCatalyst?

rolfbjarne · 2022-08-26T16:06:56Z

tests/xtro-sharpie/api-annotations-dotnet/macOS-AppKit.ignore

+!deprecated-attribute-missing! NSToolbar::setSizeMode: missing a [Deprecated] attribute
+!deprecated-attribute-missing! NSToolbar::sizeMode missing a [Deprecated] attribute
+!deprecated-attribute-missing! NSWindow::setShowsToolbarButton: missing a [Deprecated] attribute
+!deprecated-attribute-missing! NSWindow::showsToolbarButton missing a [Deprecated] attribute


rolfbjarne · 2022-08-26T16:07:25Z

tests/xtro-sharpie/macOS-AppKit.ignore

+!deprecated-attribute-missing! NSToolbar::setSizeMode: missing a [Deprecated] attribute
+!deprecated-attribute-missing! NSToolbar::sizeMode missing a [Deprecated] attribute
+!deprecated-attribute-missing! NSWindow::setShowsToolbarButton: missing a [Deprecated] attribute
+!deprecated-attribute-missing! NSWindow::showsToolbarButton missing a [Deprecated] attribute


src/appkit.cs

tj-devel709

Aside from the small nit things I mentioned and others' suggestions, LGTM!

src/appkit.cs

Co-authored-by: TJ Lambert <50846373+tj-devel709@users.noreply.github.com> Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

Everything on both APIs is CGFloat which for us is nfloat

src/appkit.cs

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

vs-mobiletools-engineering-service2 · 2022-08-29T13:45:14Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1166.Monterey'
Hash: c53a60dbc0be330f7d71e6d74433e08872d95e57 [PR build]

vs-mobiletools-engineering-service2 · 2022-08-29T13:47:23Z

❗ API diff for current PR / commit (Breaking changes)

Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
tvOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
~~watchOS~~ (no change detected)
macOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
tvOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
MacCatalyst: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
macOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

❗ API diff vs stable (Breaking changes)

Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: c53a60dbc0be330f7d71e6d74433e08872d95e57 [PR build]

vs-mobiletools-engineering-service2 · 2022-08-29T13:49:09Z

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

✅ All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
Hash: c53a60dbc0be330f7d71e6d74433e08872d95e57 [PR build]

vs-mobiletools-engineering-service2 · 2022-08-29T14:17:00Z

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

xammac_tests
monotouch-test

Pipeline on Agent
Hash: c53a60dbc0be330f7d71e6d74433e08872d95e57 [PR build]

vs-mobiletools-engineering-service2 · 2022-08-29T17:12:11Z

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 9 tests failed, 219 tests passed.

Failures

❌ introspection tests

1 tests failed, 12 tests passed.

introspection/watchOS 32-bits - simulator/Debug (watchOS 6.0): Crashed Known issue: HE0038)

Html Report (VSDrops) Download

❌ monotouch tests

8 tests failed, 15 tests passed.

monotouch-test/iOS Unified 64-bits - simulator/Debug [dotnet]: TimedOut
monotouch-test/iOS Unified 64-bits - simulator/Debug: LaunchTimedOut
monotouch-test/iOS Unified 64-bits - simulator/Debug (LinkSdk) [dotnet]: LaunchTimedOut
monotouch-test/iOS Unified 64-bits - simulator/Debug (static registrar) [dotnet]: TimedOut
monotouch-test/iOS Unified 64-bits - simulator/Release (all optimizations) [dotnet]: Failed
monotouch-test/iOS Unified 64-bits - simulator/Debug (LinkSdk): Failed
monotouch-test/iOS Unified 64-bits - simulator/Debug (static registrar): Failed
monotouch-test/iOS Unified 64-bits - simulator/Release (all optimizations): Failed

Html Report (VSDrops) Download

Successes

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

chamons · 2022-08-31T20:08:15Z

Failures are all timeouts and unrelated [FAIL] GetAllSources : System.Exception : Could not initialize an instance of the type 'AddressBook.ABAddressBook': handle is null.

Breaking change TJ has a PR for already.

[AppKit] Xcode 14 Beta 1-5

6375185

This comment has been minimized.

Sign in to view

dalexsoto requested changes Aug 26, 2022

View reviewed changes

Apply suggestions from code review

6e7db60

Co-authored-by: Alex Soto <alex@alexsoto.me>

chamons added the notes-mention Deserves a mention in release notes label Aug 26, 2022

chamons and others added 3 commits August 26, 2022 10:17

Update src/AppKit/Enums.cs

68ede50

Co-authored-by: Alex Soto <alex@alexsoto.me>

Correct type, I honestly have no idea why it was nfloat

c250cda

Merge branch 'xcode14' into xcode14_appkit

6a134f8

chamons marked this pull request as ready for review August 26, 2022 15:47

rolfbjarne requested changes Aug 26, 2022

View reviewed changes

This comment has been minimized.

Sign in to view

tj-devel709 approved these changes Aug 26, 2022

View reviewed changes

src/appkit.cs Outdated Show resolved Hide resolved

src/appkit.cs Outdated Show resolved Hide resolved

src/appkit.cs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

dalexsoto and others added 3 commits August 27, 2022 18:02

Merge remote-tracking branch 'xamarin/xcode14' into xcode14_appkit

9019c4d

Apply suggestions from code review

af24a98

Co-authored-by: TJ Lambert <50846373+tj-devel709@users.noreply.github.com> Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

[UI/NSFont] Fix UIFont API and fixes NSFont object creation.

f6d9f07

Everything on both APIs is CGFloat which for us is nfloat

dalexsoto requested review from rolfbjarne and dalexsoto August 28, 2022 02:11

This comment has been minimized.

Sign in to view

[introspection] Fix intro crasher in macOS 13

147d3c4

This comment has been minimized.

Sign in to view

rolfbjarne approved these changes Aug 29, 2022

View reviewed changes

src/appkit.cs Outdated Show resolved Hide resolved

Update src/appkit.cs

c53a60d

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

dalexsoto approved these changes Aug 29, 2022

View reviewed changes

chamons merged commit 532ad02 into xamarin:xcode14 Aug 31, 2022

chamons deleted the xcode14_appkit branch August 31, 2022 20:09

[AppKit] Xcode 14 Beta 1-5 #15778

[AppKit] Xcode 14 Beta 1-5 #15778

Conversation

chamons commented Aug 25, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

dalexsoto Aug 26, 2022

Choose a reason for hiding this comment

rolfbjarne Aug 26, 2022

Choose a reason for hiding this comment

rolfbjarne Aug 26, 2022

Choose a reason for hiding this comment

rolfbjarne Aug 26, 2022

Choose a reason for hiding this comment

rolfbjarne Aug 26, 2022

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

tj-devel709 left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Aug 29, 2022

📚 [PR Build] Artifacts 📚

Packages generated

vs-mobiletools-engineering-service2 commented Aug 29, 2022

❗ API diff for current PR / commit (Breaking changes)

❗ API diff vs stable (Breaking changes)

ℹ️ Generator diff

vs-mobiletools-engineering-service2 commented Aug 29, 2022

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

vs-mobiletools-engineering-service2 commented Aug 29, 2022

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

vs-mobiletools-engineering-service2 commented Aug 29, 2022

🔥 [CI Build] Test results 🔥

Test results

Failures

❌ introspection tests

❌ monotouch tests

Successes

chamons commented Aug 31, 2022